leonardBang commented on a change in pull request #15533: URL: https://github.com/apache/flink/pull/15533#discussion_r612319379
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalLookupJoin.scala ########## @@ -109,7 +109,7 @@ abstract class CommonPhysicalLookupJoin( cluster.getRexBuilder, input.getRowType, calcOnTemporalTable, - allLookupKeys.keys.toList.sorted.toArray, + allLookupKeys.values.toList, Review comment: minor: could you help update the comment to ` remaining condition used to filter the joined records (left input record X lookup-ed records)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org