godfreyhe opened a new pull request #15559:
URL: https://github.com/apache/flink/pull/15559


   ## What is the purpose of the change
   
   *Currently, The digest of  TableScan does not consider table hints, this can 
lead to one table used in different place with different table hints (such as 
the given example of FLINK-21627) will be treated as same table. If sub-plan 
reuse is enabled, the TableScan nodes with same table names and other extra 
digest will be merged into one. Although, Sink node will not be reused now, we 
should also let the Sink node have the table hints to make the plan more clear. 
This pr aims to fix them.*
   
   
   ## Brief change log
   
     - *The digest of TableScan should consider table hints*
     - *The digest of Sink should consider table hints*
   
   
   ## Verifying this change
   
   
   This change added tests and can be verified as follows:
   
     - *Extended TableSourceTest, LegacyTableSourceTest to verify the plan with 
source table hints.*
     - *Extended TableSourceITCase and LegacyTableSourceITCase the verify 
execution result with source table hints.*
     - *Extended TableSinkTest & LegacySinkTest to verify the plan with sink 
table hints.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ **not documented**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to