rmetzger commented on a change in pull request #15417:
URL: https://github.com/apache/flink/pull/15417#discussion_r606151322
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/scheduling/ReactiveModeITCase.java
##########
@@ -196,52 +192,91 @@ public void run(SourceContext<String> ctx) throws
Exception {
public void cancel() {
running = false;
}
+
+ @Override
+ public void close() throws Exception {
+ tracker.reportStoppedInstance();
+ }
}
- private static class ParallelismTrackingSink<T> extends
RichSinkFunction<T> {
+ private static class InstanceParallelismTracker {
+ // only notify this lock on scale-up
+ private final Object lock = new Object();
- private static final InstanceTracker instances = new InstanceTracker();
+ private volatile int instances = 0;
Review comment:
I wasn't aware that synchronization also creates a "happens-before"
memory barriers. Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
