leonardBang commented on a change in pull request #15280:
URL: https://github.com/apache/flink/pull/15280#discussion_r605621940
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LocalZonedTimestampType.java
##########
@@ -72,7 +72,8 @@
java.time.Instant.class.getName(),
Integer.class.getName(),
Long.class.getName(),
- TimestampData.class.getName());
+ TimestampData.class.getName(),
+ java.sql.Timestamp.class.getName());
Review comment:
yes, we think `java.sql.Timestamp` is enough, Supporting `LocalDateTime`
is an impossible mission which means we need pass configuration to converters,
but some place we're hard to get the configuration eg. format , serializers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
