lirui-apache commented on a change in pull request #15253:
URL: https://github.com/apache/flink/pull/15253#discussion_r604834219
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParser.java
##########
@@ -192,6 +245,8 @@
try {
// creates SessionState
startSessionState(hiveConf, catalogManager);
+ // We override Hive's grouping function. Refer to the
implementation for more details.
+ hiveShim.registerTemporaryFunction("grouping",
HiveGenericUDFGrouping.class);
Review comment:
The function also needs overriding in hive's `FunctionRegistry` so that
hive code also uses the overridden one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
