austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r601919882
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##########
@@ -269,19 +256,15 @@ public ExecutionJobVertex(
return jobVertex.getOperatorIDs();
}
- public void setMaxParallelism(int maxParallelismDerived) {
+ public void setMaxParallelism(int maxParallelism) {
Preconditions.checkState(
- !maxParallelismConfigured,
+ isMaxParallelismAutoConfigured(),
Review comment:
> It also doesn't really make sense for the maxParallelism to only be
settable if it was previously autoConfigured by the system.
👍🏼 I was able to remove the concept of "auto-configured" into SchedulerBase,
the only place it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
