wsry commented on a change in pull request #15199:
URL: https://github.com/apache/flink/pull/15199#discussion_r598061122



##########
File path: 
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -513,6 +513,30 @@
                                     + " the configured min/max size, the 
min/max size will be used. The exact size of Network Memory can be"
                                     + " explicitly specified by setting the 
min/max size to the same value.");
 
+    /**
+     * Memory used by blocking shuffle for shuffle data read (currently only 
used by sort-merge
+     * shuffle). The minimum valid value can be configured is 32M.

Review comment:
       The reason for this is that too small read memory is bad for performance 
and 32M is not a big memory overhead. Removing this restriction is also 
acceptable for me. I will remove and add some descriptions like: decreasing 
this value may impact the performance.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to