XComp commented on a change in pull request #15049:
URL: https://github.com/apache/flink/pull/15049#discussion_r597544249



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionGraphInfo.java
##########
@@ -35,15 +33,15 @@
 
     private static final long serialVersionUID = -6134203195124124202L;
 
-    private final ArchivedExecutionGraph executionGraph;
-    private final List<ErrorInfo> exceptionHistory;
+    private final AccessExecutionGraph executionGraph;

Review comment:
       That's actually a good point I haven't considered when refactoring this 
piece of code. Theoretically it should not happen that a 
`DefaultExecutionGraph` is being returned by `ExecutionGraphInfo`. But it 
should reflected by the used interface as well. I'm gonna go ahead and 
introduce a `SerializableAccessExecutionGraph` @zentol do you see any problems 
with that approach?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to