Myasuka commented on a change in pull request #15206:
URL: https://github.com/apache/flink/pull/15206#discussion_r596844124
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateSnapshotRestore.java
##########
@@ -36,8 +39,10 @@
* hint.
*
* @param readVersionHint the required version of the state to read.
+ * @param dataInputStream the current dataInputStream.
* @return a reader that reads state by key-groups, for the given read
version.
*/
@Nonnull
- StateSnapshotKeyGroupReader keyGroupReader(int readVersionHint);
+ StateSnapshotKeyGroupReader keyGroupReader(int readVersionHint,
DataInputStream dataInputStream)
Review comment:
Could you please explain why adding `dataInputStream` could distinguish
between full/inc snapshots on recovery?
Moreover, dose `StateSnapshotKeyGroupReader#readMappingsInKeyGroup(@Nonnull
DataInputView div, @Nonnegative int keyGroupId)` still need that `div` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
