[
https://issues.apache.org/jira/browse/FLINK-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235876#comment-15235876
]
ASF GitHub Bot commented on FLINK-3731:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1869#issuecomment-208532037
Thanks for the fix! +1 to merge
> Embedded SQL outer joins should fail during translation
> -------------------------------------------------------
>
> Key: FLINK-3731
> URL: https://issues.apache.org/jira/browse/FLINK-3731
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> The {{DataSetJoinRule}} sets the join type to {{JoinType.INNER}}, meaning
> that outer joins are incorrectly translated to inner joins. The match method
> of the rule should check the join type and fail to produce a valid plan if
> it's not an inner join.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
