[GitHub] [flink] wangyang0918 commented on a change in pull request #15185: [FLINK-21768][clients]Optimize system.exit() logic of CliFrontend

[GitBox]

wangyang0918 commented on a change in pull request #15185:
URL: https://github.com/apache/flink/pull/15185#discussion_r595688406



##########
File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -1124,19 +1124,19 @@ public static void main(final String[] args) {
         final List<CustomCommandLine> customCommandLines =
                 loadCustomCommandLines(configuration, configurationDirectory);
 
+        int retCode = 31;
         try {
             final CliFrontend cli = new CliFrontend(configuration, 
customCommandLines);
 
             SecurityUtils.install(new 
SecurityConfiguration(cli.configuration));
-            int retCode =
-                    SecurityUtils.getInstalledContext().runSecured(() -> 
cli.parseAndRun(args));
-            System.exit(retCode);

Review comment:
       Do you mean the Oozie will handle the system exit signal and throw an 
exception here? After then, we will go into the `catch` code blocks and call 
the system exit again.
   
   So you are suggesting to ensure that only call the `System.exit` once. Right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org