GitHub user ZackPierce opened a pull request:

    https://github.com/apache/flink/pull/1868

    FLINK-3126 : Remove accumulator type from "value" in web frontend

    The `value` field in `StringifiedAccumulatorResult` populated by 
`stringifyAccumulatorResults` previously was filled by the result of calling 
`toString()` on an `Accumulator`.  This result, exposed via the web interface, 
had the unfortunate effect of showing users the innards of a given 
Accumulator's field values and type info rather than the target value of 
interest tracked by the accumulator.
    
    Thus, this PR introduces the use of `Accumulator#getLocalValue()` for the 
`value` field set via `StringifiedAccumulatorResult#stringifyAccumulatorResults`
    
    In keeping with the extant pattern in the class, a String value of `"null"` 
is used when either the `Accumulator` or the result of `getLocalValue()` is 
`null`.
    
    Tests have been added to verify this behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ZackPierce/flink FLINK-3126

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1868.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1868
    
----
commit 2d0eab3801a9d09ac15ed356671f3248cc8881a7
Author: Zack Pierce <zpie...@newrelic.com>
Date:   2016-04-11T17:17:34Z

    FLINK-3126 : Remove accumulator type from "value" in web frontend

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to