[ 
https://issues.apache.org/jira/browse/FLINK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235342#comment-15235342
 ] 

ASF GitHub Bot commented on FLINK-2998:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r59229638
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/TwoInputNode.java 
---
    @@ -427,6 +428,14 @@ public void 
computeInterestingPropertiesForInputs(CostEstimator estimator) {
                                                }
                                        }
                                        
    +                                   if 
(child1.getInputs().iterator().hasNext()) {
    --- End diff --
    
    This change is not necessary. The data distribution should be set within 
`GlobalProperties`. I'll point you to the correct places.


> Support range partition comparison for multi input nodes.
> ---------------------------------------------------------
>
>                 Key: FLINK-2998
>                 URL: https://issues.apache.org/jira/browse/FLINK-2998
>             Project: Flink
>          Issue Type: New Feature
>          Components: Optimizer
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> The optimizer may have potential opportunity to optimize the DAG while it 
> found two input range partition are equivalent, we does not support the 
> comparison yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to