wuchong commented on a change in pull request #15195: URL: https://github.com/apache/flink/pull/15195#discussion_r594020680
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalWindowJoin.scala ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.table.planner.plan.nodes.physical.stream + +import org.apache.flink.table.api.TableException +import org.apache.flink.table.planner.plan.logical.WindowingStrategy +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode +import org.apache.flink.table.planner.plan.nodes.physical.common.CommonPhysicalJoin +import org.apache.flink.table.planner.plan.utils.PythonUtil.containsPythonCall +import org.apache.flink.table.planner.plan.utils.RelExplainUtil.preferExpressionFormat + +import org.apache.calcite.plan.{RelOptCluster, RelTraitSet} +import org.apache.calcite.rel._ +import org.apache.calcite.rel.core.{Join, JoinRelType} +import org.apache.calcite.rex.RexNode + +import scala.collection.JavaConversions._ +import scala.collection.JavaConverters._ + +/** + * The window join requires the join condition contains window starts equality of + * input tables and window ends equality of input tables. + * The semantic of window join is the same to the DataStream window join. + */ +class StreamPhysicalWindowJoin( + cluster: RelOptCluster, + traitSet: RelTraitSet, + leftRel: RelNode, + rightRel: RelNode, + joinType: JoinRelType, + // remaining join condition contains all of join condition except window starts equality + // and window end equality + remainingCondition: RexNode, + val leftWindowing: WindowingStrategy, + val rightWindowing: WindowingStrategy) Review comment: I see. You are right. Would be better to check the two window strategies in the physical node by overriding `isValid`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
