leonardBang commented on a change in pull request #15136:
URL: https://github.com/apache/flink/pull/15136#discussion_r592952977
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -262,6 +263,30 @@ class TemporalTypesTest extends ExpressionTestBase {
"2018-03-14")
}
+ private def expectExceptionThrown(
+ sqlExpr: String,
+ expected: String,
+ keywords: String,
+ clazz: Class[_ <: Throwable] = classOf[ValidationException])
+ : Unit = {
Review comment:
I noticed same style in our Flink code(eg `AggregateValidationTest`,
`CorrelateValidationTest`), and if we align in this way, the last two lines of
this function looks strange
```
: Unit = {
try {
...
} catch {
....
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
