wuchong commented on a change in pull request #15006:
URL: https://github.com/apache/flink/pull/15006#discussion_r592268616
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java
##########
@@ -119,20 +129,27 @@ public void testSetAndResetOption() throws Exception {
.asMap()
.get("pipeline.name"));
Assert.assertEquals(
- (long) DEFAULT_PARALLELISM.defaultValue(),
+ 16,
sessionContext
.getExecutionContext()
.getTableEnvironment()
.getConfig()
.getConfiguration()
- .getInteger(DEFAULT_PARALLELISM));
+ .getInteger(MAX_PARALLELISM));
Assert.assertNull(
sessionContext
.getExecutionContext()
.getTableEnvironment()
.getConfig()
.getConfiguration()
.getString(NAME, null));
+ Assert.assertTrue(
Review comment:
nit: ditto.
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java
##########
@@ -119,20 +129,27 @@ public void testSetAndResetOption() throws Exception {
.asMap()
.get("pipeline.name"));
Assert.assertEquals(
- (long) DEFAULT_PARALLELISM.defaultValue(),
+ 16,
Review comment:
nit: would be better to add comment to explain why it fallback to 16.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
