[
https://issues.apache.org/jira/browse/FLINK-21690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298756#comment-17298756
]
Yun Tang commented on FLINK-21690:
----------------------------------
[~Tony Giao] I see, do you want to fix this line duplication? I could assign
this ticket to you.
> remove redundant tolerableCheckpointFailureNumber setting in CheckpointConfig
> -----------------------------------------------------------------------------
>
> Key: FLINK-21690
> URL: https://issues.apache.org/jira/browse/FLINK-21690
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Affects Versions: 1.12.2
> Reporter: Zhengqi Zhang
> Priority: Minor
> Attachments: image-2021-03-10-18-04-34-353.png
>
>
> there is an extra setting of tolerableCheckpointFailureNumber in the
> constructor of CheckpointConfig.
> {code:java}
> public CheckpointConfig(final CheckpointConfig checkpointConfig) {
> checkNotNull(checkpointConfig);
> this.checkpointInterval = checkpointConfig.checkpointInterval;
> this.checkpointingMode = checkpointConfig.checkpointingMode;
> this.checkpointTimeout = checkpointConfig.checkpointTimeout;
> this.maxConcurrentCheckpoints = checkpointConfig.maxConcurrentCheckpoints;
> this.minPauseBetweenCheckpoints =
> checkpointConfig.minPauseBetweenCheckpoints;
> this.preferCheckpointForRecovery =
> checkpointConfig.preferCheckpointForRecovery;
> this.tolerableCheckpointFailureNumber =
> checkpointConfig.tolerableCheckpointFailureNumber;
> this.unalignedCheckpointsEnabled =
> checkpointConfig.isUnalignedCheckpointsEnabled();
> this.alignmentTimeout = checkpointConfig.alignmentTimeout;
> this.approximateLocalRecovery =
> checkpointConfig.isApproximateLocalRecoveryEnabled();
> this.externalizedCheckpointCleanup =
> checkpointConfig.externalizedCheckpointCleanup;
> this.forceCheckpointing = checkpointConfig.forceCheckpointing;
> this.forceUnalignedCheckpoints =
> checkpointConfig.forceUnalignedCheckpoints;
> this.tolerableCheckpointFailureNumber =
> checkpointConfig.tolerableCheckpointFailureNumber;
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
