KevinyhZou commented on a change in pull request #15068:
URL: https://github.com/apache/flink/pull/15068#discussion_r590975723
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java
##########
@@ -591,8 +591,7 @@ public void testStreamPartitionReadByPartitionName() throws
Exception {
Assert.assertEquals(
Arrays.asList(
- Row.of(i, "new_add", 11 + i, "2020", "10", "0" +
i).toString(),
- Row.of(i, "new_add_1", 11 + i, "2020", "10", "0" +
i).toString()),
+ Row.of(i, "new_add").toString(), Row.of(i,
"new_add_1").toString()),
Review comment:
Hello, it not missed. As we have changed to `select x,y... where ..` ,
So we only assertEquals the column x, y. The `Row.of(i, "new_add").toString(),
Row.of(i, "new_add_1").toString()),` is 2 line.
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java
##########
@@ -591,8 +591,7 @@ public void testStreamPartitionReadByPartitionName() throws
Exception {
Assert.assertEquals(
Arrays.asList(
- Row.of(i, "new_add", 11 + i, "2020", "10", "0" +
i).toString(),
- Row.of(i, "new_add_1", 11 + i, "2020", "10", "0" +
i).toString()),
+ Row.of(i, "new_add").toString(), Row.of(i,
"new_add_1").toString()),
Review comment:
Hello, it not missed. As we have changed to `select x,y... where ..` ,
So we only assertEquals the column x, y. The `Row.of(i, "new_add").toString(),
Row.of(i, "new_add_1").toString())` is 2 line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
