wuchong commented on a change in pull request #15120:
URL: https://github.com/apache/flink/pull/15120#discussion_r590020610
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestFileFactory.java
##########
@@ -198,7 +196,9 @@ public void close() throws IOException {
@Override
public TypeInformation<RowData> getProducedType() {
- return
InternalTypeInfo.ofFields(DataTypes.STRING().getLogicalType());
+ // For ScanTableSource the output type is determined by planner,
+ // the result of this method would not be used.
Review comment:
Nit: update the comment to mention the purpose of returning null is
validating the output type can be handled by planner correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
