dzikosc commented on a change in pull request #15040: URL: https://github.com/apache/flink/pull/15040#discussion_r586507995
########## File path: flink-end-to-end-tests/flink-streaming-kinesis-test/src/main/java/org/apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.kinesis.test; + +import org.apache.flink.api.common.time.Deadline; +import org.apache.flink.streaming.connectors.kinesis.testutils.KinesisPubsubClient; +import org.apache.flink.streaming.kinesis.test.containers.KinesaliteContainer; +import org.apache.flink.tests.util.TestUtils; +import org.apache.flink.tests.util.categories.TravisGroup1; +import org.apache.flink.tests.util.flink.FlinkContainer; +import org.apache.flink.tests.util.flink.SQLJobSubmission; + +import org.apache.flink.shaded.guava18.com.google.common.collect.ImmutableList; + +import com.fasterxml.jackson.databind.ObjectMapper; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.SneakyThrows; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.rules.Timeout; +import org.testcontainers.containers.Network; + +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.time.Duration; +import java.util.List; +import java.util.Properties; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; + +import static org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants.AWS_ENDPOINT; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +/** End-to-end test for Kinesis Table API using Kinesalite. */ +@Category(value = {TravisGroup1.class}) +public class KinesisTableApiITCase { + private static final String ORDERS = "orders"; + private static final String LARGE_ORDERS = "large_orders"; + + private final Path sqlConnectorKinesisJar = TestUtils.getResource(".*kinesis.jar"); + private final Network network = Network.newNetwork(); + + @ClassRule public static final Timeout TIMEOUT = new Timeout(10, TimeUnit.MINUTES); + + @Rule + public final KinesaliteContainer kinesalite = new KinesaliteContainer().withNetwork(network); + + @Rule + public final FlinkContainer flink = + FlinkContainer.builder() + .build() + .withEnv("AWS_ACCESS_KEY_ID", "fakeid") + .withEnv("AWS_SECRET_KEY", "fakekey") + .withEnv("AWS_CBOR_DISABLE", "1") + .withEnv( + "FLINK_ENV_JAVA_OPTS", + "-Dorg.apache.flink.kinesis.shaded.com.amazonaws.sdk.disableCertChecking") + .withNetwork(network) + .dependsOn(kinesalite); + + @BeforeClass + public static void setUp() { + // Required for Kinesalite. + // Including shaded and non-shaded conf to support test running from Maven and IntelliJ + System.setProperty("com.amazonaws.sdk.disableCertChecking", "1"); + System.setProperty("com.amazonaws.sdk.disableCbor", "1"); + System.setProperty( + "org.apache.flink.kinesis.shaded.com.amazonaws.sdk.disableCertChecking", "1"); + System.setProperty("org.apache.flink.kinesis.shaded.com.amazonaws.sdk.disableCbor", "1"); + } + + @Test(timeout = 120_000) + public void testTableApiSourceAndSink() throws Exception { + Properties properties = new Properties(); + properties.setProperty(AWS_ENDPOINT, kinesalite.getEndpointUrl()); + + List<Order> smallOrders = ImmutableList.of(new Order("A", 5), new Order("B", 10)); + + // Large orders have a quantity > 10 + List<Order> largeOrders = + ImmutableList.of(new Order("C", 15), new Order("D", 20), new Order("E", 25)); + + KinesisPubsubClient client = new KinesisPubsubClient(properties); + client.createTopic(ORDERS, 1, properties); + client.createTopic(LARGE_ORDERS, 1, properties); + + smallOrders.forEach(order -> client.sendMessage(ORDERS, toJson(order))); + largeOrders.forEach(order -> client.sendMessage(ORDERS, toJson(order))); + + executeSqlStatements(readSqlFile("filter-large-orders.sql")); + + List<Order> result = readAllOrdersFromKinesis(client); + assertEquals(largeOrders.size(), result.size()); + assertTrue(result.containsAll(largeOrders)); + } + + private List<Order> readAllOrdersFromKinesis(final KinesisPubsubClient client) + throws Exception { + Deadline deadline = Deadline.fromNow(Duration.ofSeconds(5)); + List<Order> orders; + do { + Thread.sleep(1000); + orders = + client.readAllMessages(LARGE_ORDERS).stream() + .map(order -> fromJson(order, Order.class)) + .collect(Collectors.toList()); + } while (deadline.hasTimeLeft() && orders.size() < 3); + + return orders; + } + + private List<String> readSqlFile(final String resourceName) throws Exception { + return Files.readAllLines(Paths.get(getClass().getResource(resourceName).toURI())); + } + + private void executeSqlStatements(final List<String> sqlLines) throws Exception { + flink.submitSQLJob( + new SQLJobSubmission.SQLJobSubmissionBuilder(sqlLines) + .addJars(sqlConnectorKinesisJar) + .build()); + } + + @SneakyThrows + private <T> String toJson(final T object) { + return new ObjectMapper().writeValueAsString(object); + } + + @SneakyThrows + private <T> T fromJson(final String json, final Class<T> type) { + return new ObjectMapper().readValue(json, type); + } + + /** Test data model class for sending and receiving records on Kinesis. */ + @Data + @EqualsAndHashCode Review comment: `@EqualsAndHashCode` is implied by `@Data` ########## File path: flink-end-to-end-tests/flink-streaming-kinesis-test/pom.xml ########## @@ -65,6 +71,13 @@ under the License. <version>${junit.version}</version> <scope>compile</scope> </dependency> + + <dependency> + <groupId>org.projectlombok</groupId> + <artifactId>lombok</artifactId> + <version>1.16.22</version> + <scope>provided</scope> + </dependency> Review comment: As the Lombok dependency is not widely used in Flink, does it bring enough value to pull it in for a single test? Have we consulted Lombok usage with Flink community ? ########## File path: flink-end-to-end-tests/flink-streaming-kinesis-test/src/main/java/org/apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.kinesis.test; + +import org.apache.flink.api.common.time.Deadline; +import org.apache.flink.streaming.connectors.kinesis.testutils.KinesisPubsubClient; +import org.apache.flink.streaming.kinesis.test.containers.KinesaliteContainer; +import org.apache.flink.tests.util.TestUtils; +import org.apache.flink.tests.util.categories.TravisGroup1; +import org.apache.flink.tests.util.flink.FlinkContainer; +import org.apache.flink.tests.util.flink.SQLJobSubmission; + +import org.apache.flink.shaded.guava18.com.google.common.collect.ImmutableList; + +import com.fasterxml.jackson.databind.ObjectMapper; +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.SneakyThrows; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.rules.Timeout; +import org.testcontainers.containers.Network; + +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.time.Duration; +import java.util.List; +import java.util.Properties; +import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; + +import static org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants.AWS_ENDPOINT; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +/** End-to-end test for Kinesis Table API using Kinesalite. */ +@Category(value = {TravisGroup1.class}) +public class KinesisTableApiITCase { + private static final String ORDERS = "orders"; + private static final String LARGE_ORDERS = "large_orders"; Review comment: As these are simple Strings, I'd qualify both names to help with readability. How about: ``` private static final String ORDERS_TOPIC = "orders"; private static final String LARGE_ORDERS_TOPIC = "large_orders"; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
