rmetzger commented on a change in pull request #15076:
URL: https://github.com/apache/flink/pull/15076#discussion_r586459901
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/runtime/BlockingShuffleITCase.java
##########
@@ -94,7 +93,6 @@ private JobGraph createJobGraph(int numRecordsToSend) {
StreamGraph streamGraph = env.getStreamGraph();
streamGraph.setGlobalDataExchangeMode(GlobalDataExchangeMode.ALL_EDGES_BLOCKING);
- streamGraph.setScheduleMode(ScheduleMode.LAZY_FROM_SOURCES);
// a scheduler supporting batch jobs is required for this job graph,
because it contains
// blocking data exchanges, and the "lazy from sources" schedule mode
is not supported by
Review comment:
comment still mentions the schedule mode
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##########
@@ -853,9 +852,9 @@ public void testIteration() {
assertEquals(iterationSourceCoLocationGroup,
iterationSinkCoLocationGroup);
}
- /** Test default schedule mode. */
+ /** Test default job type. */
@Test
- public void testDefaultScheduleMode() {
+ public void testDefaultJobType() {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
// use eager schedule mode by default
Review comment:
comment still refers to schedule mode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
