wuchong commented on a change in pull request #15005:
URL: https://github.com/apache/flink/pull/15005#discussion_r584435518



##########
File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -592,6 +593,66 @@ class TableEnvironmentTest {
     tableEnv.executeSql("UNLOAD MODULE dummy")
   }
 
+  @Test
+  def testExecuteSqlWithUseModules(): Unit = {
+    tableEnv.executeSql("LOAD MODULE dummy")
+    assert(tableEnv.listModules().sameElements(Array[String]("core", "dummy")))

Review comment:
       `assertArrayEquals` should work in Java, but yes it's hard to use in 
Scala. Comparing array's element one by one looks messing and not readable. I 
just checked `sameElements` takes order into account. Thus, I think it's fine 
to use `sameElements` here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to