kezhuw commented on a change in pull request #15039:
URL: https://github.com/apache/flink/pull/15039#discussion_r584088461
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/MetricUtilsTest.java
##########
@@ -161,7 +222,7 @@ public void testHeapMetricUsageNotStatic() throws Exception
{
}
@Test
- public void testMetaspaceMetricUsageNotStatic() throws
InterruptedException {
+ public void testMetaspaceMetricUsageNotStatic() throws Exception {
Review comment:
@XComp `testMetaspaceXyz` will fail on IBM J9(I use Eclipse OpenJ9 VM
(build openj9-0.23.0)) with NPE or `assertNotNull`. How about changing
`instantiateMetaspaceMemoryMetrics` to return `boolean`, and assume on its
returning value ? It is `VisibleForTesting`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
