xintongsong commented on a change in pull request #15015:
URL: https://github.com/apache/flink/pull/15015#discussion_r583419140
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategyTest.java
##########
@@ -49,56 +53,61 @@
@Test
public void testFulfillRequirementWithRegisteredResources() {
- final Map<InstanceID, Tuple2<ResourceProfile, ResourceProfile>>
registeredResources =
- new HashMap<>();
+ final TaskManagerInfo taskManager =
+ new FineGrainedTaskManagerRegistration(
Review comment:
Maybe introduce a `TestingTaskManagerInfo`.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -464,9 +464,7 @@ private void checkResourceRequirements() {
.getDefaultSlotResourceProfile())));
Review comment:
`availableResources` can be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
