zhuzhurk commented on a change in pull request #14868:
URL: https://github.com/apache/flink/pull/14868#discussion_r583375430
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/PointwisePatternTest.java
##########
@@ -352,28 +254,47 @@ private void testHighToLow(int highDop, int lowDop)
throws Exception {
fail("Job failed with exception: " + e.getMessage());
}
- ExecutionJobVertex target = eg.getAllVertices().get(v2.getID());
+ return eg.getAllVertices().get(v2.getID());
+ }
- int[] timesUsed = new int[highDop];
+ /** Make sure the descendant logic of building POINTWISE edges follows the
initial logic. */
+ private void testConnectionFromLowToHigh(int low, int high, int[]
expected) throws Exception {
Review comment:
I think there is no need to distinguish `highToLow` or `lowToHigh`. It
can be:
```
int testConnections(int sourceParallelism, int targetParallelism, int[][]
expectedTargetConsumedPartitions);
```
The `expectedTargetConnections` describes the `partitionNumber` of consumed
partitions for each target parallel instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
