[GitHub] [flink] bytesandwich commented on a change in pull request #15017: [FLINK-12607][rest] Introduce a REST API that returns the maxParallelism

[GitBox]

bytesandwich commented on a change in pull request #15017:
URL: https://github.com/apache/flink/pull/15017#discussion_r583293775



##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/job-detail.ts
##########
@@ -50,6 +50,8 @@ export interface JobDetailInterface {
   'start-time': number;
   'end-time': number;
   duration: number;
+  parallelism: number;
+  'job-max-parallelism': number;

Review comment:
       Done

##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfo.java
##########
@@ -41,6 +41,7 @@
     public static final String FIELD_NAME_VERTEX_ID = "id";
     public static final String FIELD_NAME_VERTEX_NAME = "name";
     public static final String FIELD_NAME_PARALLELISM = "parallelism";
+    public static final String FIELD_NAME_MAX_PARALLELISM = "max-parallelism";

Review comment:
       Done

##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobDetailsInfo.java
##########
@@ -59,6 +59,8 @@
 
     public static final String FIELD_NAME_DURATION = "duration";
 
+    public static final String FIELD_NAME_MAX_PARALLELISM = 
"job-max-parallelism";

Review comment:
       Done

##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfoTest.java
##########
@@ -83,10 +83,12 @@ protected JobVertexDetailsInfo getTestResponseInstance() 
throws Exception {
                         jobVertexMetrics,
                         "taskmanagerId3"));
 
+        int parallelism = random.nextInt();
         return new JobVertexDetailsInfo(
                 new JobVertexID(),
                 "jobVertex" + random.nextLong(),
-                random.nextInt(),
+                parallelism,
+                2 * parallelism,

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org