AHeise commented on a change in pull request #15013:
URL: https://github.com/apache/flink/pull/15013#discussion_r582760927
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -359,6 +366,16 @@ private void setChaining(Map<Integer, byte[]> hashes,
List<Map<Integer, byte[]>>
}
}
+ private static int compareHashes(byte[] hash1, byte[] hash2) {
+ for (int index = 0; index < hash1.length; index++) {
+ int diff = hash2[index] - hash1[index];
Review comment:
Hashes are currently always of the same size. However, there is no
contract on the `StreamGraphHasher` that enforces that, so I'll incorporate
your idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
