tillrohrmann commented on a change in pull request #14629:
URL: https://github.com/apache/flink/pull/14629#discussion_r582190272
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/FlinkConfMountDecorator.java
##########
@@ -150,6 +173,24 @@ private Pod decoratePod(Pod pod) {
return Collections.singletonList(flinkConfConfigMap);
}
+ private Optional<File> getTaskManagerPodTemplateFile() {
+ return kubernetesComponentConf
+ .getFlinkConfiguration()
+ .getOptional(KubernetesConfigOptions.TASK_MANAGER_POD_TEMPLATE)
+ .map(
+ file -> {
+ final File podTemplateFile = new File(file);
+ if (!podTemplateFile.exists()) {
+ throw new FlinkRuntimeException(
+ new FileNotFoundException(
+ String.format(
+ "Pod template file %s
does not exist.",
+ file)));
+ }
+ return podTemplateFile;
+ });
Review comment:
I think this breaks currently. If the user starts a cluster with
`kubernetes.pod-template-file` pointing to a local file, then the started
JobManager pod won't have this file but still tries to access it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
