wangyang0918 commented on a change in pull request #14629:
URL: https://github.com/apache/flink/pull/14629#discussion_r582076000
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/InitJobManagerDecorator.java
##########
@@ -98,7 +103,7 @@ private Container decorateMainContainer(Container container)
{
.withImagePullPolicy(kubernetesJobManagerParameters.getImagePullPolicy().name())
.withResources(requirements)
.withPorts(getContainerPorts())
Review comment:
Just like what we have described in the documentation, some fields will
always be respected. Flink provides the following list of fields that are
planned to be long-term supported: `annotations, labels, imagePullSecrets,
nodeSelector, tolerations, env, init container, sidecar container, volumes`.
The fields that will be overwritten are listed in the tables.
Adding a sanity check for the pod template in one method does not make sense
to me. Because it will also be a burden to maintain especially when we change
the internal overwrite logic or introduce new config options. I will try to
figure out whether it is feasible to log whenever we overwrite a pod template
configuration in decorators.
Currently, we already log the result pod meta and spec in the
`Fabric8FlinkKubeClient` when creating JobManager and TaskManager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
