aljoscha commented on a change in pull request #14982: URL: https://github.com/apache/flink/pull/14982#discussion_r582002919
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackendBuilder.java ########## @@ -500,9 +487,18 @@ private static void checkAndCreateDirectory(File directory) throws IOException { lastCompletedCheckpointId, numberOfTransferingThreads); } else { - checkpointSnapshotStrategy = savepointSnapshotStrategy; + checkpointSnapshotStrategy = + new RocksFullSnapshotStrategy<>( + db, + rocksDBResourceGuard, + keySerializerProvider.currentSchemaSerializer(), + kvStateInformation, + keyGroupRange, + keyGroupPrefixBytes, + localRecoveryConfig, + keyGroupCompressionDecorator); } - return new SnapshotStrategy<>(checkpointSnapshotStrategy, savepointSnapshotStrategy); + return new SnapshotStrategy<>(checkpointSnapshotStrategy); Review comment: Good catch! Removing this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org