leonardBang commented on pull request #14977: URL: https://github.com/apache/flink/pull/14977#issuecomment-784862283
> https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/sqlexec/SqlToOperationConverter.java > > ``` > else if (validated instanceof RichSqlInsert) { > SqlNodeList targetColumnList = ((RichSqlInsert) validated).getTargetColumnList(); > if (targetColumnList != null && targetColumnList.size() != 0) { > throw new ValidationException("Partial inserts are not supported"); > } > return Optional.of(converter.convertSqlInsert((RichSqlInsert) validated)); > } > ``` > > Does it need to be changed here？ I think we do not need change this piece, I suggest > https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/sqlexec/SqlToOperationConverter.java > > ``` > else if (validated instanceof RichSqlInsert) { > SqlNodeList targetColumnList = ((RichSqlInsert) validated).getTargetColumnList(); > if (targetColumnList != null && targetColumnList.size() != 0) { > throw new ValidationException("Partial inserts are not supported"); > } > return Optional.of(converter.convertSqlInsert((RichSqlInsert) validated)); > } > ``` > > Does it need to be changed here？ Nice catch, I think we can remove this check safely . @docete ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
