sjwiesman edited a comment on pull request #201: URL: https://github.com/apache/flink-statefun/pull/201#issuecomment-784384927
🔥 Very excited to see this. I did not do a code review but I spent today building a demo to get my head in the right space for the new docs and there’s one things I found surprising as a user. I'll leave it up to you two if you think my suggestions make sense. `RequestReplyHandler#handle` taking and returning a `Slice` threw me for a loop. Especially because it is not obvious how to turn a byte[] into a `Slice`. I had to find the helper class by digging through the code. Maybe this one is resolved with some additional Javadoc but it's also not clear to me why `Slice` is exposed to the user at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
