aljoscha commented on a change in pull request #14979:
URL: https://github.com/apache/flink/pull/14979#discussion_r580901535
##########
File path:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferAccessor.java
##########
@@ -225,10 +227,15 @@ public NodeId put(
*
* @param node id of the entry
*/
- public void lockNode(final NodeId node) {
+ public void lockNode(final NodeId node, final DeweyNumber version) {
Review comment:
Missing javadocs for the new parameter.
##########
File path:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferAccessor.java
##########
@@ -240,10 +247,12 @@ public void lockNode(final NodeId node) {
* @param node id of the entry
* @throws Exception Thrown if the system cannot access the state.
*/
- public void releaseNode(final NodeId node) throws Exception {
+ public void releaseNode(final NodeId node, final DeweyNumber version)
throws Exception {
Review comment:
Also missing javadocs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
