wangpeibin713 commented on a change in pull request #14863:
URL: https://github.com/apache/flink/pull/14863#discussion_r580354989
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/deduplicate/ProcTimeDeduplicateKeepLastRowFunctionTest.java
##########
@@ -92,14 +102,31 @@ public void testWithGenerateUpdateBefore() throws
Exception {
testHarness.open();
testHarness.processElement(insertRecord("book", 1L, 12));
testHarness.processElement(insertRecord("book", 2L, 11));
- testHarness.processElement(insertRecord("book", 1L, 13));
+ testHarness.processElement(insertRecord("book", 1L, 12));
testHarness.close();
// Keep LastRow in deduplicate may send UPDATE_BEFORE
List<Object> expectedOutput = new ArrayList<>();
expectedOutput.add(insertRecord("book", 1L, 12));
expectedOutput.add(updateBeforeRecord("book", 1L, 12));
- expectedOutput.add(updateAfterRecord("book", 1L, 13));
+ expectedOutput.add(updateAfterRecord("book", 1L, 12));
+ expectedOutput.add(insertRecord("book", 2L, 11));
+ assertor.assertOutputEqualsSorted("output wrong.", expectedOutput,
testHarness.getOutput());
+ }
+
+ @Test
+ public void testDeduplicateWithGenerateUpdateBefore() throws Exception {
Review comment:
ok，I think `testWithStateTtlDisabled` is better. I will change the
method name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
