aljoscha commented on a change in pull request #14913:
URL: https://github.com/apache/flink/pull/14913#discussion_r580228596
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -290,6 +294,16 @@ public RocksDBKeyedStateBackend(
this.nativeMetricMonitor = nativeMetricMonitor;
this.sharedRocksKeyBuilder = sharedRocksKeyBuilder;
this.priorityQueueFactory = priorityQueueFactory;
+ if (priorityQueueFactory instanceof HeapPriorityQueueSetFactory) {
Review comment:
Not sure I like the `instanceof` here. Could the functionality maybe me
a method on the queue factory?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
##########
@@ -348,7 +349,7 @@ public int numKeyValueStatesByName() {
}
// TODO remove this once heap-based timers are working with RocksDB
incremental snapshots!
- public boolean requiresLegacySynchronousTimerSnapshots() {
+ public boolean requiresLegacySynchronousTimerSnapshots(CheckpointType
checkpointOptions) {
Review comment:
The parameter seems to never be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
