liuyufei9527 commented on a change in pull request #14341:
URL: https://github.com/apache/flink/pull/14341#discussion_r580081667



##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -162,7 +162,9 @@ public ColumnFamilyOptions 
createColumnOptions(Collection<AutoCloseable> handles
             final long targetFileSize = 256 * 1024 * 1024;
             final long writeBufferSize = 64 * 1024 * 1024;
 
-            BloomFilter bloomFilter = new BloomFilter();
+            /* Default use Full Filters (new format) instead of Block-based 
Bloom Filter, and bits_per_key=10.
+             * https://github.com/facebook/rocksdb/wiki/RocksDB-Bloom-Filter */
+            BloomFilter bloomFilter = new BloomFilter(10, false);

Review comment:
       I'll remove this change, filter will be overwrite after if enable 
partitioned filter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to