[ 
https://issues.apache.org/jira/browse/FLINK-21375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17288190#comment-17288190
 ] 

Xintong Song commented on FLINK-21375:
--------------------------------------

A 40% regression is observed with the {{serializerHeavyString}} benchmarks, 
where the commits perfectly match FLINK-21417.
http://codespeed.dak8s.net:8000/timeline/?exe=1%2C3%2C5&base=&ben=serializerHeavyString&env=2&revs=200&equid=off&quarts=on&extr=on

I'm reverting the changes.

Also noticed FLINK-21236 which tacks migrating {{HeapMemorySegment}} use cases 
to {{HybridMemorySegment}}.

> Refactor HybridMemorySegment
> ----------------------------
>
>                 Key: FLINK-21375
>                 URL: https://issues.apache.org/jira/browse/FLINK-21375
>             Project: Flink
>          Issue Type: Task
>          Components: Runtime / Coordination
>            Reporter: Xintong Song
>            Assignee: Xintong Song
>            Priority: Major
>             Fix For: 1.13.0
>
>
> Per the discussion in [this PR|https://github.com/apache/flink/pull/14904], 
> we plan to refactor {{HybridMemorySegment}} as follows.
> * Separate into memory type specific implementations: heap / direct / native 
> (unsafe)
> * Remove {{wrap()}}, replacing with {{processAsByteBuffer()}}
> * Remove native memory cleaner logic



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to