[ https://issues.apache.org/jira/browse/FLINK-21220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286908#comment-17286908 ]
Yangze Guo commented on FLINK-21220: ------------------------------------ [~chesnay] I think it has the following benefits: - No need to check the argument type of the {{cpuCores}} when construct {{ResourceProfile}}. - No need to manually do the type conversion when call the {{ResourceProfile#getCpuCores}}. > Change the type of cpuCores in ResourceProfile to CPUResource > ------------------------------------------------------------- > > Key: FLINK-21220 > URL: https://issues.apache.org/jira/browse/FLINK-21220 > Project: Flink > Issue Type: Improvement > Components: Runtime / Coordination > Reporter: Yangze Guo > Priority: Minor > Labels: starter > > The {{cpuCores}} field in {{ResourceProfile}} should always be the > CPUResource. There is no need to generalize it to {{Resource}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)