XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578561800
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ########## @@ -835,8 +837,15 @@ public void updateAccumulators(final AccumulatorSnapshot accumulatorSnapshot) { mainThreadExecutor); } - private void startCheckpointScheduler(final CheckpointCoordinator checkpointCoordinator) { + @Override Review comment: The `CheckpointCoordinator` does not change during the lifetime of an `ExecutionGraph`. That's why, I thought of making this change to introduce the `CheckpointScheduling` interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org