rmetzger commented on a change in pull request #14923:
URL: https://github.com/apache/flink/pull/14923#discussion_r578386398
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java
##########
@@ -887,19 +897,22 @@ public void runIfState(State expectedState, Runnable
action, Duration delay) {
// ----------------------------------------------------------------
- private void transitionToState(State newState) {
- if (state != newState) {
- LOG.debug(
- "Transition from state {} to {}.",
- state.getClass().getSimpleName(),
- newState.getClass().getSimpleName());
+ @VisibleForTesting
+ <S extends State> void transitionToState(
Review comment:
why did you change the semantics of "transition to same state" from
"ignore" to "fail"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
