curcur commented on a change in pull request #14799: URL: https://github.com/apache/flink/pull/14799#discussion_r578323324
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java ########## @@ -162,14 +163,19 @@ public static CheckpointStorage load( Preconditions.checkNotNull(classLoader, "classLoader"); Preconditions.checkNotNull(configuredStateBackend, "statebackend"); - if (configuredStateBackend instanceof CheckpointStorage) { + StateBackend rootStateBackend = + (configuredStateBackend instanceof ProxyStateBackend) + ? ((ProxyStateBackend) configuredStateBackend).getProxiedStateBackend() + : configuredStateBackend; Review comment: This is the only place needing to unwrap for "state backend"; and it is because some of the backends are both state backend + checkpoint storage (for now). There are some other places to check whether it is XXXKeyedStateBackend might be cofusing with this one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org