rkhachatryan opened a new pull request #14953:
URL: https://github.com/apache/flink/pull/14953


   ## What is the purpose of the change
   
    ```
   When a savepoint is added to CompletedCheckpointStore
   all previous checkpoints will be removed if number to
   retain is 1.
   
   This makes future incremental checkpoints invalid since
   they can refer to the discarded state.
   ```
   
   ## Verifying this change
   
   Added unit tests for the `DefaultCompletedCheckpointStore` 
(`testAtLeastOneCheckpointRetained`, `testOlderSavepointSubsumed`, 
`testSubsumeAfterStoppingWithSavepoint`, `testNotSubsumedIfNotNeeded`).
   
   I test `DefaultCompletedCheckpointStore` and not the 
`CheckpointSubsumeHelper` to verify their integration.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to