rmetzger commented on a change in pull request #14928:
URL: https://github.com/apache/flink/pull/14928#discussion_r576222277
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -383,6 +394,25 @@
.withDescription(
"Configure the minimum increase in parallelism for
a job to scale up.");
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Duration> RESOURCE_WAIT_TIMEOUT =
+ key("jobmanager.declarative-scheduler.resource-wait-timeout")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(10))
+ .withDescription(
+ Description.builder()
+ .text(
+ "The maximum time the JobManager
will wait for to acquire all required resources after a job submission or
restart."
+ + "Once elapsed it will
try to run the job with a lower parallelism, or fail if the minimum amount of
resources could not be acquired.")
Review comment:
```suggestion
"The maximum time the JobManager
will wait to acquire all required resources after a job submission or restart. "
+ "Once elapsed it will
try to run the job with a lower parallelism, or fail if the minimum amount of
resources could not be acquired.")
```
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -392,6 +394,25 @@
.withDescription(
"Configure the minimum increase in parallelism for
a job to scale up.");
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Duration> RESOURCE_WAIT_TIMEOUT =
+ key("jobmanager.declarative-scheduler.resource-wait-timeout")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(10))
Review comment:
aren't the k8s e2e tests failing because 10 seconds is too aggressive.
Maybe set the default to 30 ?
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -383,6 +394,25 @@
.withDescription(
"Configure the minimum increase in parallelism for
a job to scale up.");
+ @Documentation.Section({
+ Documentation.Sections.EXPERT_SCHEDULING,
+ Documentation.Sections.ALL_JOB_MANAGER
+ })
+ public static final ConfigOption<Duration> RESOURCE_WAIT_TIMEOUT =
+ key("jobmanager.declarative-scheduler.resource-wait-timeout")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(10))
+ .withDescription(
+ Description.builder()
+ .text(
+ "The maximum time the JobManager
will wait for to acquire all required resources after a job submission or
restart."
+ + "Once elapsed it will
try to run the job with a lower parallelism, or fail if the minimum amount of
resources could not be acquired.")
+ .linebreak()
+ .text(
+ "Increasing this value will make
the cluster more resilient against temporary resources shortages (e.g., there
is more time for a failed TaskManager to be restarted),"
Review comment:
```suggestion
"Increasing this value will make
the cluster more resilient against temporary resources shortages (e.g., there
is more time for a failed TaskManager to be restarted), "
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
