wuchong commented on a change in pull request #14905: URL: https://github.com/apache/flink/pull/14905#discussion_r575673126
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/logical/windowingSpecs.scala ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.logical + +import org.apache.flink.table.types.logical.LogicalType +import org.apache.flink.table.types.logical.utils.LogicalTypeChecks +import org.apache.flink.util.TimeUtils.formatWithHighestUnit + +import java.time.Duration +import java.util.Objects + +/** + * Logical representation of a windowing strategy. + */ +sealed trait WindowingStrategy { + val window: WindowSpec + val timeAttributeType: LogicalType + val isRowtime: Boolean = LogicalTypeChecks.isRowtimeAttribute(timeAttributeType) + def toSummaryString(inputFieldNames: Array[String]): String +} + +case class TimeAttributeWindowingStrategy( + timeAttribute: Int, + timeAttributeType: LogicalType, + window: WindowSpec) + extends WindowingStrategy { + override def toSummaryString(inputFieldNames: Array[String]): String = { + val windowing = s"time_col=[${inputFieldNames(timeAttribute)}]" + window.toSummaryString(windowing) + } +} + +case class WindowAttachedWindowingStrategy( + windowStart: Int, + windowEnd: Int, + timeAttributeType: LogicalType, + window: WindowSpec) + extends WindowingStrategy { + override def toSummaryString(inputFieldNames: Array[String]): String = { + val windowing = s"win_start=[${inputFieldNames(windowStart)}], " + + s"win_end=[${inputFieldNames(windowEnd)}]" + window.toSummaryString(windowing) + } +} + +// ------------------------------------------------------------------------------------------------ +// Window specifications +// ------------------------------------------------------------------------------------------------ + +/** + * Logical representation of a window specification. + */ +sealed trait WindowSpec { + + def toSummaryString(windowing: String): String + + def hashCode(): Int + + def equals(obj: Any): Boolean +} + +case class TumblingWindowSpec(size: Duration) extends WindowSpec { Review comment: No. This is planned in another PR, because this PR has been super large. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
