pnowojski edited a comment on pull request #14847:
URL: https://github.com/apache/flink/pull/14847#issuecomment-777432314


   > Could one of you review d9330d5 
   
   d9330d5 looks weakly good to me. Weakly as from my experience it's easy to 
miss some corner cases in the cancelation/cleanup code and I wouldn't be 
surprised that it would cause some test failures.
   
   edit: there seems to be a test failure in your newly added test ` 
SavepointITCase.testStopWithSavepointFailingAfterSnapshotCreation`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to