KarmaGYZ commented on a change in pull request #14897:
URL: https://github.com/apache/flink/pull/14897#discussion_r573589144
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ResourceCounter.java
##########
@@ -35,11 +37,12 @@
* associated counts. The counts are always positive (> 0).
*/
public final class ResourceCounter {
Review comment:
Regarding the performance concerns, I agree that this might be premature
optimization. We need a deeper investigation to prove it hurts performance.
TBH, I don't think it can hurt the performance in scheduling a lot. I thought
it would be more beneficial to optimize performance rather than keeping it
immutable when I prepared this PR. Thanks for your explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
