wuchong commented on a change in pull request #14748:
URL: https://github.com/apache/flink/pull/14748#discussion_r569292537
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsAggregatePushDown.java
##########
@@ -135,15 +135,16 @@
* the aggregates or nothing and return whether all the aggregates have
been pushed down into
* the source.
*
- * <p>Note: Use the passed {@code producedDataType} instead of {@link
TableSchema#toPhysicalRowDataType()}
- * for describing the final output data type when creating {@link
TypeInformation}. The projection
- * of grouping keys and aggregate values is already considered in the
given output data type.
- * The passed data type pattern is {@code grouping sets} + {@code
aggregate function result},
- * downstream storage need to organize the returned aggregate data
strictly in this manner.
+ * <p>Note: Use the passed {@code producedDataType} instead of {@link
+ * TableSchema#toPhysicalRowDataType()} for describing the final output
data type when creating
+ * {@link TypeInformation}. The projection of grouping keys and aggregate
values is already
+ * considered in the given output data type. The passed data type pattern
is {@code grouping
+ * sets} + {@code aggregate function result}, downstream storage need to
organize the returned
+ * aggregate data strictly in this manner.
*
- * @param groupingSets a array list of the grouping sets. In the example
mentioned in
- * {@link SupportsAggregatePushDown}, this method would receive the
groupingSets of
- * {code List([1, 4]) which is equivalent to {@code List(["name",
"type"])}.
+ * @param groupingSets a array list of the grouping sets. In the example
mentioned in {@link
+ * SupportsAggregatePushDown}, this method would receive the
groupingSets of {code List([1,
Review comment:
`{code List([1` ==> `{@code List([1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
