xintongsong commented on a change in pull request #14647:
URL: https://github.com/apache/flink/pull/14647#discussion_r568307727
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotStatusSyncer.java
##########
@@ -79,6 +79,7 @@ void initialize(
*
* @param instanceId of the task manager
* @param slotReport reported
+ * @return whether to trigger the resource requirement check
Review comment:
"whether the previous allocations can be applied"
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncer.java
##########
@@ -224,11 +224,12 @@ public void reportSlotStatus(InstanceID instanceId,
SlotReport slotReport) {
LOG.debug(
"Received slot report for unknown task manager with
instance id {}. Ignoring this report.",
instanceId);
- return;
+ return false;
}
LOG.debug("Received slot report from instance {}: {}.", instanceId,
slotReport);
+ boolean triggerCheckRequirement = false;
Review comment:
I think triggering checking requirements is a decision made by
`FineGrainedSlotManager`, which is not something the syncer needs to
understand. I would suggest `canApplyPreviousAllocations`.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java
##########
@@ -88,6 +88,8 @@
private boolean sendNotEnoughResourceNotifications = true;
+ private Set<JobID> unfulfillableJobs = new HashSet<>();
Review comment:
Should be cleared in `suspend()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
