wuchong commented on a change in pull request #14813:
URL: https://github.com/apache/flink/pull/14813#discussion_r567589468
##########
File path:
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFactoryTest.java
##########
@@ -206,6 +206,29 @@ public void testDeserializeWithEscapedFieldDelimiter()
throws IOException {
assertEquals(expected, actual);
}
+ @Test
+ public void testDeserializeWithDisableQuoteCharacter() throws IOException {
Review comment:
`CsvFormatFactoryTest` is used to verify the received options can be
converted into expected serializer/deserializer. The parse/unparse logic should
be tested in `CsvRowDataSerDeSchemaTest`.
Could you add a test in `CsvRowDataSerDeSchemaTest` to test deserialization
with quote disabled ? And add a DeserializationSchema assertEquals test in
`CsvFormatFactoryTest#testDisableQuoteCharacter`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
