aljoscha commented on a change in pull request #14782:
URL: https://github.com/apache/flink/pull/14782#discussion_r566236853
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/NestedStateMapSnapshot.java
##########
@@ -48,6 +53,35 @@ public NestedStateMapSnapshot(NestedStateMap<K, N, S>
owningStateMap) {
super(owningStateMap);
}
+ @Override
+ public Iterator<StateEntry<K, N, S>> getIterator(
+ @Nonnull TypeSerializer<K> keySerializer,
+ @Nonnull TypeSerializer<N> namespaceSerializer,
+ @Nonnull TypeSerializer<S> stateSerializer,
+ @Nullable StateSnapshotTransformer<S> stateSnapshotTransformer) {
+ if (stateSnapshotTransformer == null) {
+ return owningStateMap.iterator();
+ } else {
+ return StreamSupport.stream(
+
Spliterators.spliteratorUnknownSize(owningStateMap.iterator(), 0),
+ false)
+ .map(entry -> transformEntry(stateSnapshotTransformer,
entry))
+ .filter(Objects::nonNull)
+ .iterator();
+ }
+ }
+
+ private StateEntry<K, N, S> transformEntry(
+ StateSnapshotTransformer<S> stateSnapshotTransformer,
StateEntry<K, N, S> entry) {
+ S transformedState =
stateSnapshotTransformer.filterOrTransform(entry.getState());
+ if (transformedState != null) {
+ return new StateEntry.SimpleStateEntry<>(
Review comment:
Looks very good now, yes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
